Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: git action Run Rpc tests without cache, some tests fail #1439

Open
fishseabowl opened this issue Feb 6, 2024 · 2 comments
Open

bug: git action Run Rpc tests without cache, some tests fail #1439

fishseabowl opened this issue Feb 6, 2024 · 2 comments
Labels
bug Something isn't working stale

Comments

@fishseabowl
Copy link
Contributor

Bug Report

Madara version:

Current behavior:
In PR #1420 checks, some tests failed due to the following code returning Err

std::fs::File::open(env!("CARGO_MANIFEST_DIR").to_owned() + "/" + path_to_sierra).unwrap(),

Details:
https://github.com/keep-starknet-strange/madara/actions/runs/7806424794/job/21292853182?pr=1420
running 4 tests
test fails_already_declared ... FAILED
test fail_validation_step ... FAILED
test works_with_storage_change ... FAILED
test fail_execution_step_with_no_storage_change ... FAILED

failures:

---- fails_already_declared stdout ----
error: test failed, to rerun pass --test starknet_add_declare_transaction
thread 'fails_already_declared' panicked at starknet-rpc-test/src/utils.rs:173:95:
called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

---- fail_validation_step stdout ----
thread 'fail_validation_step' panicked at starknet-rpc-test/src/utils.rs:173:95:
called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

---- works_with_storage_change stdout ----
thread 'works_with_storage_change' panicked at starknet-rpc-test/src/utils.rs:173:95:
called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

---- fail_execution_step_with_no_storage_change stdout ----
thread 'fail_execution_step_with_no_storage_change' panicked at starknet-rpc-test/src/utils.rs:173:95:
called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

failures:
fail_execution_step_with_no_storage_change
fail_validation_step
fails_already_declared
works_with_storage_change

Expected behavior:

Passed the test

Steps to reproduce:

Related code:

insert short code snippets here

Other information:

@fishseabowl fishseabowl added the bug Something isn't working label Feb 6, 2024
@chop-pixel
Copy link

perhaps try modifying the test to handle the error slightly more gracefully as while also providing a more informative error message in such instances where the file cannot be opened:

let file_path = format!("{}/{}", env!("CARGO_MANIFEST_DIR"), path_to_sierra);
let file = std::fs::File::open(&file_path)
.expect(&format!("Failed to open file at path: {}", file_path));

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants