Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add pallet test for declareV0 #1603

Open
tdelabro opened this issue May 15, 2024 · 13 comments
Open

dev: add pallet test for declareV0 #1603

tdelabro opened this issue May 15, 2024 · 13 comments
Assignees
Labels
enhancement New feature or request

Comments

@tdelabro
Copy link
Collaborator

In crates/pallets/starknet/src/tests/declare_tx.rs add a test that is using DeclareTransaction::V0 instead of the V1 we are using everywhere.

@tdelabro tdelabro added the enhancement New feature or request label May 15, 2024
@elielnfinic
Copy link
Contributor

I can take this.

@raizo07
Copy link

raizo07 commented May 15, 2024

@tdelabro I'll like to work on this, kindly assign me.

@tdelabro
Copy link
Collaborator Author

@elielnfinic please go ahead

@tdelabro
Copy link
Collaborator Author

@raizo07 let me see if I can find some other task for you!

@tdelabro
Copy link
Collaborator Author

@raizo07 do you think you can do the same with InvokeTransaction::V0?
under crates/pallets/starknet/src/tests/invoke_tx.rs

@raizo07
Copy link

raizo07 commented May 15, 2024

@tdelabro Yes, I can. You'll have to create it as a separate issue I guess.

@tdelabro
Copy link
Collaborator Author

@raizo07 you can start working on it without an issue don't worry

@raizo07
Copy link

raizo07 commented May 17, 2024

@raizo07 you can start working on it without an issue don't worry

I'm on it now, thanks.

@tdelabro
Copy link
Collaborator Author

@raizo07 when you create your PR add me as reviewer. Or tag me in the PR discussion

@raizo07
Copy link

raizo07 commented May 17, 2024

@raizo07 when you create your PR add me as reviewer. Or tag me in the PR discussion

@tdelabro Okay I will once I'm done.

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 17, 2024
@tdelabro
Copy link
Collaborator Author

@raizo07 still working on it?

@raizo07
Copy link

raizo07 commented Jun 17, 2024

@raizo07 still working on it?

Yes I am. I sent you a message on Telegram earlier.

@github-actions github-actions bot removed the stale label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants