Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: make HasherT methods accept iterator rather than &[Felt] as argument #1613

Open
tdelabro opened this issue May 29, 2024 · 7 comments · May be fixed by #1621
Open

dev: make HasherT methods accept iterator rather than &[Felt] as argument #1613

tdelabro opened this issue May 29, 2024 · 7 comments · May be fixed by #1621
Assignees
Labels
enhancement New feature or request stale

Comments

@tdelabro
Copy link
Collaborator

tdelabro commented May 29, 2024

True for compute_hash_on_wrapper and compute_hash_on_elements.
Then check everywhere if it can allow us to remove some .collect() that were only there to respect the arg type.

Also pleases add a default impl for compute_hash_on_wrappers and make it call compute_hash_on_elements and remove the concrete impl of it for poseidon and pedersen.

@tdelabro tdelabro added the enhancement New feature or request label May 29, 2024
@Gerson2102
Copy link
Contributor

Can i work on this?

@tdelabro
Copy link
Collaborator Author

actually finish #1607 before claiming this one

@fishseabowl
Copy link
Contributor

@tdelabro could I take this? Thanks

@tdelabro
Copy link
Collaborator Author

@fishseabowl can you rebase #1526 and #1610 before?

@fishseabowl
Copy link
Contributor

@tdelabro #1526 and #1610 have been rebased. Please help to review them. Thanks

@tdelabro
Copy link
Collaborator Author

perfect! Go ahead

@fishseabowl fishseabowl linked a pull request May 31, 2024 that will close this issue
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants