Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update typos tool to CI to automate typo detection #1620

Open
AdventureSeeker987 opened this issue May 31, 2024 · 2 comments
Open

feat: update typos tool to CI to automate typo detection #1620

AdventureSeeker987 opened this issue May 31, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AdventureSeeker987
Copy link
Contributor

Feature Request

#224 Add a spell checker and fix spellings But this tool is outdated,

with typos(especially suitable for rust, cairo) you can find typos like:

error: `Coversion` should be `Conversion`
  --> ./crates/primitives/starknet-inherent/src/lib.rs:44:13
   |
44 |     GasPriceCoversionError(String, u128),
   |             ^^^^^^^^^
   |
error: `whis` should be `this`, `whisk`
  --> ./crates/pallets/starknet/src/tests/deploy_account_tx.rs:356:55
    |
356 | fn given_contract_run_deploy_account_braavos_tx_works_whis_hardware_signer() {
    |                                                       ^^^^
    |
error: `succeded` should be `succeeded`
  --> ./crates/pallets/starknet/src/tests/query_tx.rs:124:74
    |
124 |         assert!(fee_estimation_result.unwrap().is_err(), "Fee estimation succeded");
    |                                                                          ^^^^^^^^
    |
error: `inital` should be `initial`
  --> ./crates/pallets/starknet/src/transaction_validation.rs:99:25
   |
99 |                 let mut inital_gas = block_context.versioned_constants().tx_initial_gas();
   |                         ^^^^^^
   |
error: `inital` should be `initial`
  --> ./crates/pallets/starknet/src/transaction_validation.rs:105:97
    |
105 |                         tx.run_validate_entrypoint(&mut state, tx_context, &mut resources, &mut inital_gas, true)
    |                                                                                                 ^^^^^^
    |
error: `inital` should be `initial`
  --> ./crates/pallets/starknet/src/transaction_validation.rs:110:97
    |
110 |                         tx.run_validate_entrypoint(&mut state, tx_context, &mut resources, &mut inital_gas, true)
    |                                                                                                 ^^^^^^
    |
error: `possiblility` should be `possibility`
  --> ./crates/pallets/starknet/src/lib.rs:772:39
    |
772 |                         // There is a possiblility of false negative, where a previous tx execution you make the future
    |                                       ^^^^^^^^^^^^

Describe Preferred Solution

  • use typos-action Integrate github action and check subsequent typos
  • fixe all checked typos
  • exclude xxx,refer to the configuration file for details.

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

YES

@AdventureSeeker987 AdventureSeeker987 added the enhancement New feature or request label May 31, 2024
@Josh-121
Copy link

Josh-121 commented Jun 5, 2024

Can work on this. Please assign

@devcollinss
Copy link

@AdventureSeeker987 Can I be assigned this task? I will deliver it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants