Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Add Reason to UcwaEvents #36

Open
elav000 opened this issue Nov 9, 2017 · 3 comments
Open

Add Reason to UcwaEvents #36

elav000 opened this issue Nov 9, 2017 · 3 comments

Comments

@elav000
Copy link

elav000 commented Nov 9, 2017

For ParticipantInvitation events, if the state is 'Failure' the 'Reason' object from the response is not passed down, so the client does not get any detailed information regarding the failure.

If Reason is added to the Event object, it can also be passed to the event delegates. I have made this change locally and added another delegate to pass along the reason information. I'm not sure how best to solve for all cases?

Example below:

"events" : [{
"link" : {
"rel" : "participantInvitation",
"href" : "/ucwa/oauth/v1/applications/asdf/communication/participantInvitations/..."
},
"status" : "Failure",
"_embedded" : {
"participantInvitation" : {
"direction" : "Outgoing",
"importance" : "Normal",
"state" : "Failed",
...
},
"rel" : "participantInvitation"
}
},
"reason" : {
"code" : "RemoteFailure",
"subcode" : "Declined",
"message" : "Your invitation was declined."
},
"type" : "completed"
}
]

@elav000 elav000 changed the title Add Reason to Events Add Reason to UcwaEvents Nov 10, 2017
@baywet baywet self-assigned this Dec 21, 2017
@baywet
Copy link
Collaborator

baywet commented Dec 21, 2017

Hi @elav000 sorry for the late reply.
Do you think you could author a PR for that?

@kenakamu
Copy link
Owner

kenakamu commented May 4, 2018

didn't we already done this?

@baywet
Copy link
Collaborator

baywet commented May 4, 2018

I think we did it for errors but not for events so far.

@baywet baywet removed their assignment Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants