Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find and Replace in Editor stops working sometimes after flow execution #4130

Open
wrussell1999 opened this issue Jun 25, 2024 · 6 comments
Open
Assignees
Labels
area/frontend Need some frontend code changes bug Something isn't working

Comments

@wrussell1999
Copy link
Member

Feature description

Add a Find (Control + F) and Replace feature to allow people to easily change multiple instances of a word in their flows and files.

@wrussell1999 wrussell1999 added the enhancement New feature or request label Jun 25, 2024
@anna-geller anna-geller added the area/frontend Need some frontend code changes label Jun 25, 2024
@MilosPaunovic
Copy link
Member

@wrussell1999 I'm kind of confused here, as that functionality already exists in the editor, or am I missing something?

Screen.Recording.2024-06-25.133832.mp4

@wrussell1999
Copy link
Member Author

@MilosPaunovic Hmm odd. It wasn't working for me so I gave it a hard refresh and it now shows up. Trying to see if I can replicate this bug. If I can't, I will close the issue.

When I pressed Control + F (or in my case Cmd + F on Mac), no search box would display (none in Kestra or Chrome). Also no UI option to trigger it either. Maybe something we'd want to add for accessibility?

@wrussell1999
Copy link
Member Author

@MilosPaunovic I've been able to re-create it. When I execute this blueprint, when I go back to the editor, it no longer works.

Screen.Recording.2024-06-25.at.13.05.19.mov

@wrussell1999
Copy link
Member Author

Same for namespace files and when I go between tabs in the flow

Screen.Recording.2024-06-25.at.13.05.59.mov

@wrussell1999
Copy link
Member Author

Broken when I go between flows too

Screen.Recording.2024-06-25.at.13.06.34.mov

@wrussell1999
Copy link
Member Author

wrussell1999 commented Jun 25, 2024

Refreshing seems to fix it

Screen.Recording.2024-06-25.at.13.07.19.mov

@wrussell1999 wrussell1999 added bug Something isn't working and removed enhancement New feature or request labels Jun 25, 2024
@wrussell1999 wrussell1999 changed the title Add Find and Replace to Editor Find and Replace in Editor stops working sometimes after flow execution Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Need some frontend code changes bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

3 participants