Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical bug with subscriber deletion #384

Closed
roshanjonah opened this issue Jun 4, 2021 · 6 comments
Closed

Critical bug with subscriber deletion #384

roshanjonah opened this issue Jun 4, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@roshanjonah
Copy link

Version:

  • listmonk: v1.0.0
  • OS: Ubuntu

Description of the bug and steps to reproduce:

  • Create two different lists preferably with two different sets of subscribers
  • Go to one of the lists and check the first checkbox to select all first page subscribers
  • Once options appear at the top, choose the "Select all xx subscribers" option
  • Click on "Delete"

Wait for a bit and all the subscribers across all the lists get deleted. Not just the one in the list you selected.

What it should be doing?

  • Deleting only the subscribers selected across the pages in that list alone - not across all the lists.

Screenshots:
Subscribers___listmonk-2

@roshanjonah roshanjonah added the bug Something isn't working label Jun 4, 2021
@knadh
Copy link
Owner

knadh commented Jun 4, 2021

This is expected behaviour.

A subscriber is a first class citizen entity that is connected to lists via subscriptions (table: subscriber_lists [subscriber_id, list_id]). When you delete a subscriber, you're wiping the entity off the database including all their relationships. To remove a subscriber from the list, you've to edit the subscriber and remove the particular list relationship and not delete the subscriber itself.

The screenshot is of the global list of subscribers filtered by a list and the UI and the beahviour is consistent with the "All subscribers" view as well.

@roshanjonah
Copy link
Author

Oh! The above screenshot is actually a specific list view. I kind of understand that but still don't understand why all subscribers have to be deleted when the list only contains 59. I had two lists in the system. One list had 150,000 emails and the second list which you see here had 59. So when I selected the option "Select all 59" and click "Delete", I don't understand why it would delete the 150k as well as the 59 I selected here in this specific list. 😕

Not sure if I am explaining correctly but happy to explain it another way @knadh

@knadh
Copy link
Owner

knadh commented Jun 4, 2021

So when I selected the option "Select all 59" and click "Delete", I don't understand why it would delete the 150k as well as the 59 I selected here in this specific list.

Ah, this wasn't apparent in your original description. If all subscribers got deleted and not just the ones you selected on the UI (59), it's a bug.

I hope you had a backup 🤯

@roshanjonah
Copy link
Author

Nope didn't have it and it was all wiped clean and since all tables are linked via IDs - it didn't help with any other data in the DB. Pretty terrible place to be so thought I'd notify you guys right away hoping nobody else loses their data this way 👍 Def learned my lesson of having working backups - took it lightly

@knadh
Copy link
Owner

knadh commented Jun 4, 2021

Nope didn't have it and it was all wiped clean and since all tables are linked via IDs

Argh ;( Will investigate and fix this today. Terrible.

@knadh knadh self-assigned this Jun 4, 2021
@knadh knadh closed this as completed in bbffbbc Jun 4, 2021
@knadh
Copy link
Owner

knadh commented Jun 4, 2021

This is fixed. Will do a new release tomorrow with this and a couple of other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants