Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set a "website address" #432

Closed
atbe opened this issue Aug 14, 2021 · 3 comments
Closed

Ability to set a "website address" #432

atbe opened this issue Aug 14, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@atbe
Copy link

atbe commented Aug 14, 2021

Is your feature request related to a problem? Please describe.

As of today, the settings allows you to configure a Root URL. This URL is used for:

  • The anchor on the header image sent in system emails (like confirmation emails)
  • The base URL for the links included in emails sent by the system
  • The base URL for media that is uploaded to the listmonk server
  • ... and more

The problem with this is that it assumes that the Root URL is the URL that subscribers should hit when clicking on things like the logo inside of an invite email.

The biggest annoyance is that when a user receives a confirm susbcription button, the anchor on the image links to the Root URL which links to the listmonkl, which means the user sees this:

image

Describe the solution you'd like

In addition to the Root URL, I'd propose a Site URL which can be described as the url of a website that owns the newsletter.

What would use this url:

  • The anchor on the header image sent in system emails (like confirmation emails)

What would not use this url:

  • The base URL for the links included in emails sent by the system
  • The base URL for media that is uploaded to the listmonk server
  • ... Anything that has to link back to the listmonk server
@atbe atbe added the enhancement New feature or request label Aug 14, 2021
@atbe
Copy link
Author

atbe commented Aug 14, 2021

This file sets the header image to the Root URL which imo should just be set to nothing unless there's a configurable Website address

<a href="{{ RootURL }}"><img src="{{ LogoURL }}" alt="listmonk" /></a>

@knadh
Copy link
Owner

knadh commented Aug 14, 2021

Makes sense. This is a valid problem.

This file sets the header image to the Root URL which imo should just be set to nothing unless there's a configurable Website address

I think it's best to remove the link from the logo in the template entirely rather than introduce a new global Site URL configuration just to link that one logo. Installations that need to customize these templates can always do that easily by copying the templates and passing to listmonk with the --static-dir flag.

@knadh knadh self-assigned this Aug 14, 2021
@knadh knadh closed this as completed in ccee852 Aug 14, 2021
@atbe
Copy link
Author

atbe commented Aug 15, 2021

I think it's best to remove the link from the logo in the template entirely rather than introduce a new global Site URL configuration just to link that one logo. Installations that need to customize these templates can always do that easily by copying the templates and passing to listmonk with the --static-dir flag.

I agree, this seems like a reasonable compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants