Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracked Link URLs with an ampersand are being encoded by text editor when saving to Links table #844

Closed
bamboowonder opened this issue Jun 20, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bamboowonder
Copy link

listmonk 2.1 binary
ubuntu 20.04 server and client.
chrome browser

Steps to recreate:
create campaign and with the body of the email:  this is my bold link
select that text and click the create-link button in editor.
paste in this url: https://github.com?this=test&that=test2
select "Track Link"
click Save.
Start/Send Campaign

In PG the url value saved in Link table is: https://github.com?this=test&that=test2

When clicking the link in the received email, it is unfurled as: https://github.com?this=test&that=test2

Note: that if I don't click "Track Link", the URL is not encoded/mangled.
So it seems like the process of saving the URL to the Links table is mangling the ampersand (&).
Or the url isn't being url-decoded when unfurled.

@bamboowonder bamboowonder added the bug Something isn't working label Jun 20, 2022
@bamboowonder
Copy link
Author

bamboowonder commented Jun 20, 2022

When I create the link using markdown, it looks like the URL is not encoded/mangled in the Links table,
[https://github.com?this=test&that=test2](https://github.com/?this=test&that=test2)

but it is encoded/mangled when being unfurled after click
[https://github.com?this=test&that=test2](https://github.com/?this=test&that=test2)

@knadh knadh self-assigned this Jun 26, 2022
@knadh knadh closed this as completed in c84837f Jul 11, 2022
@bamboowonder
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants