-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify pipeline function config with selector #3304
Comments
For cases where there is a specific KRM type that maps to a specific function, as with ApplyReplacements, my preferred solution is a function catalog mechanism, so that it doesn't need to be specified in the Kptfile at all. We just added a temporary hack to add the apply-replacements function to the Kptfile automatically in the UI, because I forget to do that half the time when running demos. |
Filed #3339 for the catalog-based mapping mechanism. Are there other use cases where a selector would be desirable? In general, I do think we need more flexibility with respect to where inputs come from. Other examples: |
A good point was raised in slack: It seems more appropriate to use KRM-based references and selectors than file paths. We need to think about how this would interplay with other mechanisms, such as replay-based updates: #3329. And bulk package creation: #3347. |
This is a good candidate someone to contribute to |
Given this config
I would love to see the ability to reference the function config like this instead:
This change carries with it quite a few advantages:
The disadvantage I see is mostly the introduction of footguns:
The text was updated successfully, but these errors were encountered: