Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speciy p and q when executing embed instead of during creation #27

Open
RemyLau opened this issue Oct 30, 2021 · 1 comment
Open

Speciy p and q when executing embed instead of during creation #27

RemyLau opened this issue Oct 30, 2021 · 1 comment

Comments

@RemyLau
Copy link
Contributor

RemyLau commented Oct 30, 2021

Originally done so following the node2vec source code. It makes sense to specify these parameters during the embedding function call, so that when embedding with different settings of p and q, we do not need to load the save graph object over and over again.

The only catch is that for PreComp, need to make sure each time we change the p and q settings, we need to rerun the preprocessing function.

@RemyLau
Copy link
Contributor Author

RemyLau commented Oct 30, 2021

Leave workers, verbose, extend as optional input to __init__, those could be fixed at creation time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant