Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fCO2_transpiration_mod is not used. #42

Closed
kuadrat opened this issue Jul 22, 2024 · 1 comment
Closed

fCO2_transpiration_mod is not used. #42

kuadrat opened this issue Jul 22, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kuadrat
Copy link
Owner

kuadrat commented Jul 22, 2024

The option to make use of this should be provided in modvegesite$calculate_PETeff.

Whether or not this can or should be controlled through CO2_growth_factor is still open for debate.

Low urgency, since the transpiration mod has very little effect in practice.
@kuadrat kuadrat added bug Something isn't working good first issue Good for newcomers labels Jul 22, 2024
@kuadrat
Copy link
Owner Author

kuadrat commented Aug 29, 2024

Has been implemented in 539e30d

@kuadrat kuadrat closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuadrat