Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor verber and fix client-side throttling due to client init misconfiguration #8900

Merged
merged 4 commits into from
Apr 10, 2024
Merged

feat: refactor verber and fix client-side throttling due to client init misconfiguration #8900

merged 4 commits into from
Apr 10, 2024

Conversation

floreks
Copy link
Member

@floreks floreks commented Apr 10, 2024 •
edited

API

  • Use default replicas when deploying dashboard with make helm and make helm-release
  • Remove metrics code from cronjob list as it does not directly own any resources that could generate metrics

Common (Client)

  • Rewrite verber client:
    • Use dynamic client
    • Use discovery client with cache for kind to group-version-resource mapping (no need for hardcoding and initializing a bunch of clients on our side anymore)
    • Use merge patch for resource updates to avoid update conflicts when resource changes in the background
  • Fix an issue with initializing baseConfig used to create a client. It wasn't correctly defaulting QPS/Burst causing metrics gathering to throttle significantly. Fixes ui updates seem to be too slow #8835

Web

  • Add metrics display to replication controller list

@floreks floreks added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 10, 2024
@floreks floreks self-assigned this Apr 10, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 10, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #8900 (5310d3f) into master (6becc85) will decrease coverage by 0.42%.
Report is 1 commits behind head on master.
The diff coverage is 7.87%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8900      +/-   ##
==========================================
- Coverage   37.62%   37.20%   -0.42%     
==========================================
  Files         256      255       -1     
  Lines       11187    11149      -38     
  Branches      158      158              
==========================================
- Hits         4209     4148      -61     
- Misses       6727     6790      +63     
+ Partials      251      211      -40

maciaszczykm
maciaszczykm approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fbcde7d into master Apr 10, 2024
15 checks passed
@floreks floreks deleted the api/raw-resource-update branch April 10, 2024 13:21
kireque pushed a commit to kireque/home-ops that referenced this pull request Apr 10, 2024
@kireque-bot
fix(helm-chart): update helm release kubernetes-dashboard to 7.3.1 (#450
0dda5e1 
)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kubernetes-dashboard](https://github.com/kubernetes/dashboard) |
patch | `7.3.0` -> `7.3.1` |

---

### Release Notes

<details>
<summary>kubernetes/dashboard (kubernetes-dashboard)</summary>

###
[`v7.3.1`](https://github.com/kubernetes/dashboard/releases/tag/kubernetes-dashboard-7.3.1)

[Compare
Source](https://github.com/kubernetes/dashboard/compare/kubernetes-dashboard-7.3.0...kubernetes-dashboard-7.3.1)

#### What's Changed

- chore(chart): bump chart to 7.3.1 by
[@&#8203;floreks](https://github.com/floreks) in
[kubernetes/dashboard#8902
- feat: refactor verber and fix client-side throttling due to client
init misconfiguration by [@&#8203;floreks](https://github.com/floreks)
in
[kubernetes/dashboard#8900

**Full Changelog**:
kubernetes/dashboard@kubernetes-dashboard-7.3.0...kubernetes-dashboard-7.3.1

#### Installation

```sh
helm repo add kubernetes-dashboard https://kubernetes.github.io/dashboard/
helm upgrade --install kubernetes-dashboard kubernetes-dashboard/kubernetes-dashboard --create-namespace --namespace kubernetes-dashboard
```

#### Compatibility

| Kubernetes version | 1.27 | 1.28 | 1.29 |
|--------------------|-----|-----|-----|
| Compatibility            | ?   |   ?   |   ✓    |

-   `✓` Fully supported version range.
- `?` Due to breaking changes between Kubernetes API versions, some
features might not work correctly in the Dashboard.

#### Images

    docker.io/kubernetesui/dashboard-api:1.4.3
    docker.io/kubernetesui/dashboard-auth:1.1.3
    docker.io/kubernetesui/dashboard-metrics-scraper:1.1.1
    docker.io/kubernetesui/dashboard-web:1.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yODIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI4Mi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees

@floreks floreks

@maciaszczykm maciaszczykm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui updates seem to be too slow
3 participants
@floreks @k8s-ci-robot @maciaszczykm