Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Global styles theme aware #102

Open
kuldeepkeshwar opened this issue Sep 20, 2020 · 3 comments
Open

Make Global styles theme aware #102

kuldeepkeshwar opened this issue Sep 20, 2020 · 3 comments
Labels
enhancement New feature or request feature_request Hacktoberfest

Comments

@kuldeepkeshwar
Copy link
Owner

kuldeepkeshwar commented Sep 20, 2020 •
edited
Loading

Right now, Global component doesn't support the theme prop.
i.e

<Global styles={`
 color: {({theme)=>theme.colors.brand}
`}/>

doesn't work.

Expectation:

Make Global component theme aware like styled.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.86. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@kuldeepkeshwar kuldeepkeshwar added enhancement New feature or request Hacktoberfest labels Sep 20, 2020
@kuldeepkeshwar kuldeepkeshwar mentioned this issue Sep 20, 2020
Merged
@danedavid
Copy link
Contributor

@kuldeepkeshwar Can I look into this?

@kuldeepkeshwar
Copy link
Owner Author

@kuldeepkeshwar Can I look into this?

Sure @danedavid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature_request Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuldeepkeshwar @danedavid