Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-jest can't import jest-config if the node_modules directory isn't flattened #854

Closed
iclanton opened this issue Nov 6, 2018 · 8 comments · May be fixed by procrafts/kata-diamond#20, procrafts/kata-diamond#21 or procrafts/kata-diamond#22

Comments

@iclanton
Copy link
Contributor

iclanton commented Nov 6, 2018

Issue :

ts-jest seems to assume that consumers are using npm or yarn, which both flatten the node_modules folder and allow packages to import dependencies that are not declared in their package.json. The flattened node_modules folder assumption doesn't hold true for other package managers like pnpm and yarn's plug-and-play feature.

Expected behavior :

ts-jest should be able to resolve jest-config even if the node_modules directory doesn't have flattened dependencies.

Fix

Here's the fix: #853

@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 16, 2018

One thing I forgot to mention, #853 didn't update changelog :)

@iclanton
Copy link
Contributor Author

It looks like the CHANGELOG.md is only updated when the package is released. Is there an intermediate place where changelog entries are supposed to go before releases?

@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 16, 2018

Hmm I think you are right. It is automatically done once the package is published. Sorry for the inconvenience 👍

@iclanton
Copy link
Contributor Author

Do you know when the package will be published? It'd be great to start consuming this fix.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 16, 2018

Cc @kulshekhar . I don't know when but kul will take care of it :)

@kulshekhar
Copy link
Owner

I'll try to get this done over the weekend

@iclanton
Copy link
Contributor Author

Thanks!

@kulshekhar
Copy link
Owner

This has been published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment