Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Text Animation to static leaves some balls still lit #6

Open
lancewilhelm opened this issue Jan 27, 2020 · 2 comments
Open
Assignees
Labels
bug Something isn't working scrollingText

Comments

@lancewilhelm
Copy link
Owner

This is due to the the state of the animation being changed in the middle of writing the new clock time. Can solve one of two ways:

-Reduce the amount of time it takes to write the clock and update text, only updating when a change in the system has occurred
-Making sure that the clock writing is complete before executing and animation shift. This could be done by calling the animation update from elsewhere than the flask api.

@lancewilhelm lancewilhelm self-assigned this Jan 27, 2020
@lancewilhelm lancewilhelm added bug Something isn't working scrollingText labels Jan 27, 2020
@lancewilhelm lancewilhelm changed the title Changing Text Animation leaves some balls still lit Changing Text Animation to static leaves some balls still lit (excluding time) Jan 31, 2020
@lancewilhelm lancewilhelm changed the title Changing Text Animation to static leaves some balls still lit (excluding time) Changing Text Animation to static leaves some balls still lit Jan 31, 2020
@lancewilhelm
Copy link
Owner Author

Fine tuning this issue.

This happens specifically when we go from scrolling to static for anything other than time. The balls do not reset to the origin and some balls stay lit. It is as if the text state is overwritten completely.

This is evident because if you apply a new BG color after applying the static animation the text that was frozen is overwritten.

@lancewilhelm
Copy link
Owner Author

Update:
With the newest code it is not as much of a problem anymore. It still does this from time to time. Need to get some more info and really find the root cause of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scrollingText
Projects
None yet
Development

No branches or pull requests

1 participant