Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithJob failing to find where it is running on some environments, resulting in test pass #2

Open
lanvstn opened this issue Jun 26, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lanvstn
Copy link
Owner

lanvstn commented Jun 26, 2023

There are some environments where WithJob thinks it is never running on the targeted pod, resulting in all tests passing everywhere but nothing happening.

2 problems to be addressed:

  • The main issue should be fixed
  • Need to add a safeguard to detect this (if you are not on a controller and you are not running ANY WithJob functions then something is off
@lanvstn lanvstn added the bug Something isn't working label Jun 26, 2023
@lanvstn lanvstn self-assigned this Jun 26, 2023
@lanvstn lanvstn added this to the v0.1.0 milestone Jun 26, 2023
@lanvstn
Copy link
Owner Author

lanvstn commented Jun 28, 2023

This should be fixed in 2f68b2e

I did not add the safeguard mainly because it requires the user to call a cleanup method on Kutest (which would detect the 0 runs) and I have not yet convinced myself this is worth it.

Will close this ticket after some more testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant