Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right to left script support #109

Closed
omidMolaverdi opened this issue Jul 7, 2020 · 8 comments
Closed

Right to left script support #109

omidMolaverdi opened this issue Jul 7, 2020 · 8 comments
Assignees

Comments

@omidMolaverdi
Copy link

Thanks for the great package. I know that with proper fonts, the package supports right-2-left (R2L) scripts however the direction of letters on the photo is not right. Github issue does not allow me to upload a photo but the concept is easy to imagine. Let the R2L name is wonS nhoJ (from right to left it is John snow), then the current implementation of the picture would have JS in it that is read as Snow John because of the R2L nature of the language. I can temporarily suppress the problem by allowing only one letter of the word but could be much better to support the right direction of the script.

@omidMolaverdi
Copy link
Author

Hi,

is there any update on this thread?

@uyab
Copy link
Contributor

uyab commented Sep 10, 2020

Sorry for late response. I'm not familiar with RTL, but if I understand you correctly, we just need to reverse the initials.

normal -> RTL
BHW -> WHB
JS -> SJ
A -> A

@omidMolaverdi
Copy link
Author

@uyab yes that is right!

@abdullahessam
Copy link

@uyab any update about the RTL vesion ?

@uyab uyab self-assigned this Feb 9, 2021
@uyab uyab closed this as completed in d338fe0 Feb 9, 2021
@uyab
Copy link
Contributor

uyab commented Feb 9, 2021

Hi @abdullahessam, would you like to check dev-master, add "rtl" => true to your config/laravolt/avatar.php and check if its working?

@omidMolaverdi
Copy link
Author

wow well done

@abdullahessam
Copy link

thank you @uyab for this update i think you did n't the case well so here is an example for the problem my name is
abdullah essam so the expected letters is AE and this is happen correct but in RTL language like arabic for example
محمد عبدالله the expected letters should be م ع but the actual is ع م so we just need to auto support the rtl language i have no idea what well the users input in English or in arabic
any way thank you for your effort and really appreciate it

@uyab
Copy link
Contributor

uyab commented Feb 12, 2021

Here is sample output using "rtl" => true and RTL font Amiri:
image

Any screenshot or live demo are welcome, I still don't get where the problem is 🤔

Font: https://fonts.google.com/specimen/Amiri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants