Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runLinter should determine the target module by asking Lake #795

Open
semorrison opened this issue May 13, 2024 · 2 comments · May be fixed by #811
Open

runLinter should determine the target module by asking Lake #795

semorrison opened this issue May 13, 2024 · 2 comments · May be fixed by #811

Comments

@semorrison
Copy link
Collaborator

No description provided.

@austinletson
Copy link
Contributor

austinletson commented May 26, 2024

I created draft PR #811, in which the current target module is either the first lean_exe root module or the module corresponding to the first lean_lib in Lake's environment. However, I assume we want a more flexible default.

What criteria should we use to determine the target module(s)? Are there cases where we want to run the linter on multiple modules by default?

If we are okay with linting multiple modules by default, what about "lint all modules inside either a default target lean_exe root or default target lean_lib in the Lake workspace"?

@austinletson austinletson linked a pull request May 26, 2024 that will close this issue
@austinletson
Copy link
Contributor

I have updated #811 to use any root modules of lean_exe or lean_lib default targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants