Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Config and Settings coherent names #142

Open
jankapunkt opened this issue Sep 15, 2022 · 1 comment
Open

Make Config and Settings coherent names #142

jankapunkt opened this issue Sep 15, 2022 · 1 comment

Comments

@jankapunkt
Copy link
Member

Currently we have a Config to control app-wide configurations, which itself uses settings.json as source. We should use one of the names for both.

@maliyildiz1 @turndownfawad what do you think we should use as name, settings or config?

@turndownfawad
Copy link
Contributor

There are settings, options, preferences and then there is a configuration.

If it's not something users can decide to change within the app for themselves, i.e. it's meant for devs only anyway, I advise using configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants