-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add a module-info.java in order to make it a module. #16
Comments
Could you contribute a PR? |
done :-) |
@joehei Thanks for the PR. It seems to break our tests... Presumably the issue is that it breaks backward compatibility with Java 8. Many users are going to stick with Java 8. It seems unwise to break compatibility with Java 8. Is there a way around this? |
I believe the standard approach is to compile everything targeting Java 8, except for the If the library is used on Java 9+ and placed on the module-path, then the module-info file is used. Otherwise, if the code is placed on the class-path, or is used on Java 8, then the module-info file is ignored. Note this is not the same thing as the multi-release JAR feature. |
Please add a module-info.java in order to make it a module.
The text was updated successfully, but these errors were encountered: