Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling of hidden form fields in template macros #106

Open
bladams opened this issue Aug 5, 2019 · 0 comments
Open

Simplify handling of hidden form fields in template macros #106

bladams opened this issue Aug 5, 2019 · 0 comments

Comments

@bladams
Copy link
Contributor

bladams commented Aug 5, 2019

If we remove the automatic call to render_hidden we could avoid the additional complexity of filtering out hidden fields and just rely on our own macros to render the fields.

{% if not f.widget.input_type == 'hidden' %}

Care will need to be taken to make this change since this may cause problems where we use the block form of the macro or explicitly provide field names since the CSRF token field will no longer be rendered automatically in those cases.

This applies to both the horizontal.html and horizontal_b4.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant