Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DHT] Don't add peers to the routing table who falsely advertise the DHT protocol #808

Closed
jacobheun opened this issue Mar 2, 2020 · 1 comment
Closed

[DHT] Don't add peers to the routing table who falsely advertise the DHT protocol #808

jacobheun opened this issue Mar 2, 2020 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Milestone
go-ipfs 0.7

Comments

@jacobheun
Copy link

As a followup to libp2p/go-libp2p#778,

  • Evaluate routing table addition based on protocols advertised in IDENTIFY.
    - Risk/edge case: a malicious actor could advertise the DHT protocol and never actually speak it. Make sure to cover this case by evicting the peer.

we should protect against the scenario where a malicious peer advertises the DHT protocol but doesn't actually support it. Their inclusion in the DHT could pollute the routing table and result in slow/unnecessary queries.

Success Criteria

  • A peer that advertises the DHT protocol, but does not respond to queries will not be added to the routing table.
@jacobheun jacobheun added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 2, 2020
@jacobheun jacobheun mentioned this issue Mar 2, 2020
Closed
@jacobheun jacobheun added this to the go-ipfs 0.6 milestone Mar 2, 2020
@jacobheun jacobheun modified the milestones: go-ipfs 0.6, go-ipfs 0.7 Apr 20, 2020
@marten-seemann marten-seemann transferred this issue from libp2p/go-libp2p Jan 27, 2023
@guillaumemichel
Copy link
Contributor

addressed by #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
go-ipfs 0.7
Development

No branches or pull requests
2 participants
@jacobheun @guillaumemichel