Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring incoming dht message while not in server mode #838

Closed
thewaytoai opened this issue Apr 14, 2023 · 10 comments
Closed

ignoring incoming dht message while not in server mode #838

thewaytoai opened this issue Apr 14, 2023 · 10 comments
Labels
good first issue Good issue for new contributors

Comments

@thewaytoai
Copy link

github.com/libp2p/go-libp2p v0.24.2

I have no idea why my node shows this error. Is it normal or anything wrong in my network?
@Shawn-Huang-Tron
Copy link

Shawn-Huang-Tron commented Apr 23, 2023

Me too. It's appeared frequently and I can't ignore because the log level don't work.

@MarcoPolo MarcoPolo transferred this issue from libp2p/go-libp2p May 1, 2023
@MarcoPolo
Copy link
Contributor

log line:

logger.Errorf("ignoring incoming dht message while not in server mode")

@MarcoPolo
Copy link
Contributor

Should be an easy fix, @Shawn-Huang-Tron or @thewaytoai, want to take a stab at fixing this? We could probably just make it a debug log.

@Shawn-Huang-Tron
Copy link

I think that change it to a debug log is enough. Thanks.

@MarcoPolo MarcoPolo added the good first issue Good issue for new contributors label May 9, 2023
@lidel
Copy link
Member

lidel commented May 22, 2023

triage note: @Jorropo said he is working on a patch :^)

@Jorropo
Copy link
Contributor

Jorropo commented May 22, 2023

I thought I could fix it, I was wrong, changing it to debug looks fine.

@Jorropo Jorropo removed their assignment May 22, 2023
@GheisMohammadi
Copy link
Contributor

hey team, any update on this issue?

@MarcoPolo
Copy link
Contributor

@GheisMohammadi want to volunteer a fix?

@GheisMohammadi
Copy link
Contributor

Certainly! I've already submitted the necessary changes (#860)

@Jorropo
Copy link
Contributor

Jorropo commented Aug 10, 2023

#860 looks good but we should investigate how we are receiving message, the stream handler shouldn't be visible if you are a dht client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new contributors
Projects
None yet
Development

No branches or pull requests

7 participants