Set backend_not_found route status when any backends are not found #12565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… found Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
olix0r
approved these changes
May 10, 2024
the-wondersmith
added a commit
to the-wondersmith/linkerd2
that referenced
this pull request
May 15, 2024
* origin/policy-feat-grpcroute-status-support: chore(ci): merge fixes from origin/main build(deps): bump tj-actions/changed-files from 44.3.0 to 44.4.0 (linkerd#12588) build(deps): bump github.com/fatih/color from 1.16.0 to 1.17.0 (linkerd#12590) chore(ci): Remove conditional integration testing (linkerd#12591) build(deps-dev): bump sinon from 17.0.1 to 17.0.2 in /web/app (linkerd#12587) build(deps): bump github.com/prometheus/client_golang (linkerd#12586) build(deps): bump thiserror from 1.0.59 to 1.0.60 (linkerd#12585) Revert "Fix destination staleness issue when adding EndpointSlices (linkerd#12427)" (linkerd#12589) Add outbound index metrics to the policy controller (linkerd#12429) build(deps): bump tj-actions/changed-files from 44.3.0 to 44.4.0 (linkerd#12588) build(deps): bump github.com/fatih/color from 1.16.0 to 1.17.0 (linkerd#12590) chore(ci): Remove conditional integration testing (linkerd#12591) build(deps-dev): bump sinon from 17.0.1 to 17.0.2 in /web/app (linkerd#12587) build(deps): bump github.com/prometheus/client_golang (linkerd#12586) build(deps): bump thiserror from 1.0.59 to 1.0.60 (linkerd#12585) Revert "Fix destination staleness issue when adding EndpointSlices (linkerd#12427)" (linkerd#12589) Set backend_not_found route status when any backends are not found (linkerd#12565) Add outbound index metrics to the policy controller (linkerd#12429) Signed-off-by: Mark S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy controller sets a status on HttpRoute resources depending on the state of the backends. If all the backends can be resolved, it should set a resolved_ref status and if any of the backends cannot be resolved, it should set a backend_not_found status.
We update the logic to reflect this. Additionally, this resolves the edge case where an empty list of backends was resulting in a backend_not_found status instead of a resolved_refs status.