Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weights of the variables must be positive #29

Open
llrs opened this issue Apr 26, 2019 · 0 comments
Open

Weights of the variables must be positive #29

llrs opened this issue Apr 26, 2019 · 0 comments
Assignees
Labels

Comments

@llrs
Copy link
Owner

llrs commented Apr 26, 2019

I don't know if mathematically is reasonable but the fact that a contribution of a variable can be negative is strange.

For instance a gene might be needed to go down, but still its contribution (sgcca_result$a$gene[1, 1]) is (or should be) positive. Otherwise the interpretation of the weight is difficult because if you take it as an absolute value you are saying that it is as important to go up than to go down.
Test something on these lines, probably with sequential implementation too. (forcing all the weights in a to be positive via abs)

@llrs llrs added the question label Apr 26, 2019
@llrs llrs self-assigned this Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant