Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep higher level abstraction for runtime memory orders on atomics #743

Open
bcardosolopes opened this issue Jul 15, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bcardosolopes
Copy link
Member

#731 adds CIRGen support for non-constant memory orders all the way down to LLVM.

To keep CIR a bit more simple and easier to analyze, we could change atomic operations to support the non-constant version as well and do the same lowering during LoweringPrepare instead (see clang/test/CIR/CodeGen/atomic-runtime.cpp for the example currently generated). This also opens the possibility of folding atomic operations into the constant version once we start doing some inline in CIR.

@bcardosolopes bcardosolopes added enhancement New feature or request good first issue Good for newcomers labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant