Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mb-reledit-copy_dates.user.js: Copy dates on recordings” script only works if used as first action after "Edit Relationships" on a release #90

Open
vzell opened this issue Aug 28, 2023 · 4 comments

Comments

@vzell
Copy link

vzell commented Aug 28, 2023

When I try to use the “Copy dates on recordings” script from loujine it must be the FIRST action after pressing the “Edit Relationships” tab on a release. Otherwise it does just nothing.

My typical use case is copying dates of a live event to all the performers of a recording. First of all it ONLY works if the date is already set on the recordings “place” (it will NOT work if the recording has an “event” set with the date of the live live event.

But what really bugs me is that the script only works when it is executed right after pressing “Edit Relationships” as the FIRST event.

The other bug has already been mentioned. Pressing one of the two script buttons “Copy Dates” or “Removes Dates” has no visual feedback except that it either works when being the FIRST action after “Edit Relationships” or it only pretends doing its work and adding a comment to the notes section if it is NOT called as the FIRST action after “Edit Relationships”

@vzell
Copy link
Author

vzell commented Aug 29, 2023

I'm using Tampermonkey v4.19.0 on Chrome

@vzell
Copy link
Author

vzell commented Nov 11, 2023

Any progress on this ?

@vzell
Copy link
Author

vzell commented Apr 11, 2024

When you have a couple of entries where the script should act upon, it recently stops after filling in the first edit with the right data but it doesn't "press" the OK button by itself. If I do it manually the script proceeds to the next edit and again waits on the confirmation dialog. This eventually goes on until all edits have been done.

@cslowinski
Copy link

cslowinski commented Apr 21, 2024

When you have a couple of entries where the script should act upon, it recently stops after filling in the first edit with the right data but it doesn't "press" the OK button by itself. If I do it manually the script proceeds to the next edit and again waits on the confirmation dialog. This eventually goes on until all edits have been done.

It appears the query selector is not finding the button element. I modified my local copy to resolve this by replacing:
82querySelector('.dialog-content button.positive').click();
with
82: const dialog = document.getElementById('edit-relationship-dialog');
83: dialog.querySelector('button.positive').click();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants