Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mb-reledit-set_instruments does nothing #91

Open
highstrung opened this issue Nov 16, 2023 · 1 comment
Open

mb-reledit-set_instruments does nothing #91

highstrung opened this issue Nov 16, 2023 · 1 comment

Comments

@highstrung
Copy link

After selecting instruments to change and clicking apply, nothing happens.
I think this is a simple fix to change on line 32 to use attr.typeID instead of attr.type.id :

|| rel.attributes.map(attr => attr.typeID).includes(fromAttrId)

Making that change locally seems to work for me at least (Tampermonkey 4.19, Chrome, Windows 11).

@highstrung
Copy link
Author

highstrung commented Nov 16, 2023

Actually that's not correct. The change above makes it add the new instrument, but as a new rel rather than editing the existing rel. Looks like there are similar changes needed elsewhere in the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant