Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LZ4SafeUtils#commonBytes should use Arrays#mismatch #151

Open
jpountz opened this issue Oct 31, 2019 · 3 comments
Open

LZ4SafeUtils#commonBytes should use Arrays#mismatch #151

jpountz opened this issue Oct 31, 2019 · 3 comments

Comments

@jpountz
Copy link
Collaborator

jpountz commented Oct 31, 2019

When it's ok to start requiring Java 9+ (maybe now is fine since Java 11 is the current LTS release?) we should implement LZ4SafeUtils#commonBytes using Arrays#mismatch. It yielded a good compression speedup on the Lucene implementation of LZ4 compression.
@odaira
Copy link
Member

odaira commented Oct 31, 2019

Good question.... I'll reach out to important consumers of lz4-java. I can think of Kafka, Cassandra, and Spark. Would you remember anything else?

@jpountz
Copy link
Collaborator Author

jpountz commented Nov 7, 2019

This sounds like a good start to me!

@ijuma
Copy link

ijuma commented Nov 30, 2019

We should consider doing this via MethodHandle when the method is available. Kafka will continue to support Java 8 for a while, I believe.

@Tim-Brooks Tim-Brooks mentioned this issue Sep 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ijuma @jpountz @odaira