Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify readme #13

Open
vincerubinetti opened this issue Nov 20, 2019 · 0 comments
Open

clarify readme #13

vincerubinetti opened this issue Nov 20, 2019 · 0 comments

Comments

@vincerubinetti
Copy link

vincerubinetti commented Nov 20, 2019

This section is a bit confusing:

This will generate two of three possible actions:

MY_FETCH_STARTED
MY_FETCH_SUCCEEDED
MY_FETCH_FAILED
MY_FETCH_ENDED

I think you mean to say "will always generate three of the following actions"?

Here is my proposed language:

This will generate a `MY_FETCH_STARTED` action when the fetch is started, then a `MY_FETCH_SUCCEEDED` or `MY_FETCH_FAILED` action depending on whether an error is thrown/caught in `api.fetch()`, and finally a `MY_FETCH_ENDED` action when the fetch has ended (regardless of success or failure).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant