Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstreaming it? #17

Open
yoshimo opened this issue Nov 25, 2023 · 5 comments
Open

Upstreaming it? #17

yoshimo opened this issue Nov 25, 2023 · 5 comments
Labels
question Further information is requested

Comments

@yoshimo
Copy link

yoshimo commented Nov 25, 2023

Have you considered making this part of ESPHome itself and create a pull request like the Optolink Team does in esphome/esphome#4453 ?
@mampfes
Copy link
Owner

mampfes commented Dec 10, 2023

From my experience, it creates a lot of extra effort to merge a component into esphome (or HomeAssistant) main branch and then maintain it there. Therefore I don't have plans to do this at the moment.

@mampfes mampfes added the question Further information is requested label Dec 10, 2023
@yoshimo
Copy link
Author

yoshimo commented Dec 10, 2023

Would be nice to at least get feedback and then decide if it's worth the time right now.

@yoshimo
Copy link
Author

yoshimo commented Dec 15, 2023

https://esphome.io/components/sml.html is offered upstream, does this differ significantly?

@mampfes
Copy link
Owner

mampfes commented Dec 16, 2023

SML and D0 are 2 different communication protocols, but both use OBIS codes.

@yoshimo
Copy link
Author

yoshimo commented Dec 16, 2023

ah ok, so not synonym and still needed to become mainlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoshimo @mampfes