Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case for '21st' (not '21th') dataset in sample #81

Closed
metalmine opened this issue Mar 11, 2020 · 3 comments
Closed

Special case for '21st' (not '21th') dataset in sample #81

metalmine opened this issue Mar 11, 2020 · 3 comments
Labels
bug Something isn't working samples Something to do with the samples.

Comments

@metalmine
Copy link

Describe the bug

There's no logic for 21st data set, it becomes 21th dataset.

Which Blazor project type is your bug related to?

  • Client-Side
  • Server-Side

Which charts does this bug apply to?

Any of them that can Add Datasets

To Reproduce

Steps to reproduce the behavior:
Click Add dataset until you hit 21+

Expected behavior

Show [21st Dataset]

Screenshots

https://imgur.com/a/tVLCFiN

@metalmine metalmine added the bug Something isn't working label Mar 11, 2020
@Joelius300
Copy link
Contributor

Thanks for the report.

Currently there are a lot of things that need work. I would rather focus on those instead of polishing the samples. As far as I'm concerned the samples show the usage of the library even though they aren't perfect. I hope you understand that it's more important to me to drive the library forwards instead of using my very limited time for the samples.

@Joelius300 Joelius300 added the samples Something to do with the samples. label Mar 12, 2020
@metalmine
Copy link
Author

Absolutely, I just wanted to document it.

@Joelius300 Joelius300 changed the title Adding datasets to the sample Special case for '21st' (not '21th') dataset in sample Mar 22, 2020
@Joelius300
Copy link
Contributor

I'm going to close this because from now on we'll use the same form as Chart.js which is "Dataset x". I think we should be able to avoid this situation this time around :) Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working samples Something to do with the samples.
Projects
None yet
Development

No branches or pull requests

2 participants