GitHub: Soft-Navigation to and within Actions will not work! #53
Comments
Some important follow-up regarding Because it is blocked by #50 (presumably an unidentified UXP bug), I have been conducting some "experiments" here 😜 , where I have re-enabled SN in // TEMPORARY: hard-disable Turbo navigation to prevent memory leaks in Pale Moon
document.addEventListener("DOMContentLoaded", () => {
Turbo.session.elementIsNavigatable = (e) => false;
Turbo.session.formMode = "off";
Turbo.session.willFollowLinkToLocation = (l, ll, e) => false;
const FrameElement = document.createElement("turbo-frame").constructor;
FrameElement.delegateConstructor.prototype.shouldInterceptNavigation = (e, s=null) => false
});has always been enough to get back SN working in GH with Starting with recent snapshot For the time being, I won't be submitting a Kind regards. |
That caused by 5e1d254, I do not use palefill, and forgot that. Here is the patch: const element = mutation.target;
+ if (element.tagName === "TURBO-FRAME") continue;
const CEdef = element.__CE_definition;@martok This patch is work, means that the observer from CE polyfill has not completely stopped working. Maybe there are more issues which caused by it. Originally posted by @SeaHOH in #50 (comment) |
Browser: Serpent v52.9.0 (2022-08-24) (32-bit)
Extension version:
palefill-1.22-3-git-20221016-g01a436b(the most recent snapshot where soft navigation (aka "turbo") isn't disabled)
STR:
1st test:
By default, the
<> Codetab should have been selected 😉 ...Actionstab; the blue line on top will start to move to the right very slowly, end result being:2nd test:
By default, the
All workflowsvertical tab should have been selected...pages-build-deploymentvertical tab; result (as previously):DESCRIPTION: This has started happening just a few days ago, when MS started messing (again) with the
Actionstab 😡 (read from "them" here 😉 ) ; below is an excerpt fromWeb Console:I am by no means Javascript savvy, but my searching skills tell me it's most probably:
microsoft/TypeScript#40454 😞
UXP does have support for IntersectionObserver, first implemented in Fx55, but, as linked in the documentation, support for
options.rootother thanElementwas first implemented in Fx76...WORKAROUND: Blocking the culprit script in uBO offers a kludge:
NB: In
palefill-1.23+, "soft" navigation has been disabled, thus this issue has been "swept under the rug" 😜 ; but, Web/Error Consoles will still generate messages about the culprit script(s) 😠 ...The text was updated successfully, but these errors were encountered: