Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up clang config #17

Open
php1ic opened this issue Jan 21, 2024 · 2 comments
Open

Set up clang config #17

php1ic opened this issue Jan 21, 2024 · 2 comments

Comments

@php1ic
Copy link
Contributor

php1ic commented Jan 21, 2024

Is there any interest to set up configuration for either, or both, of clang-format and clang-tidy?

I'm happy to start work on this, but don't think it's a quick task, so if the project is not interested in implementing I wont.

@ferdymercury
Copy link
Collaborator

My two cents: I don't consider it prioritary

@php1ic
Copy link
Contributor Author

php1ic commented Jan 28, 2024

Agreed, they are mainly quality of life changes and low priority, but definitely nice things to have.

I think the main issue is that both configs have a lot of options to decide on. Other projects appear to use inbuilt configs and make tweaks as required.

Suggested method with clang-format is to squash all changes into a single commit then add commit hash to a git config file to not steam-roll git blame output - link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants