In contact:addrType the elements sp, pc (contact::Address fields province, postal_code) are optional

[kmkaplan]

The elements sp, pc are optional but the struct Address in module contact makes them compulsory.

Here is the schema definition from RFC 5733, page 31

<complexType name="addrType">
  <sequence>
    <element name="street" type="contact:optPostalLineType"
     minOccurs="0" maxOccurs="3"/>
    <element name="city" type="contact:postalLineType"/>
    <element name="sp" type="contact:optPostalLineType"
     minOccurs="0"/>
    <element name="pc" type="contact:pcType"
     minOccurs="0"/>
    <element name="cc" type="contact:ccType"/>
  </sequence>
</complexType>

Should I fix this and submit PR?

[djc]

Hi @kmkaplan, so we (@InstantDomain) did most of the maintenance on epp-client for the past year or so. Recently we decided to fork it under the instant-epp name, where we changed the library completely to rely on a new deserialization/serialization library for XML that we built called instant-xml. As such, we will no longer be spending time on epp-client, but if you're interested in trying out instant-epp (I'm curious what you're using this for!) we'd be happy to take your PRs there.

[kmkaplan]

@djc Thanks for the redirect, I'll have a look at instant-epp.

[djc]

(FWIW, the fork is still young so it likely has many of the same data model issues as epp-client, though I think it might be better at dealing with different ways of encoding XML namespaces.)