2022-03-28 weekly planning

[kgodey]

About

At the start of each week, we start a discussion covering Mathesar's progress, team member check ins, and general updates. Everyone is welcome to add a new topic to discuss or to comment on existing topics.

Discussion topics

• Last Week in Mathesar
• Frontend priorities
• Backend priorities
• Design priorities
• Product priorities
• Comms Assignee schedule
• Dominykas' check in
• Brent's check in
• Pavish's check in
• Ghislaine's check in
• Kriti's check in
• Sean's check in
• Mukesh's check in

Weekly check-in

@centerofci/mathesar-core please post your weekly check-in as a top-level response and edit the discussion topics above to add your check in as a topic. Others are also welcome to respond.

Prompts:

• How did your most recent work go?
• What are you planning to work on soon?
• Do you anticipate any dependencies or blockers that someone else on the team can help you with?

If you'd like to add anything else to your check-in that's not related to the prompts, feel free to do so.

[kgodey]

Last Week in Mathesar

Feedback Requested

• Data Explorer Specs mathesar-wiki#38 (draft)

Complete

• Discussions:
  • Enums, enumerations and database types #1184
  • New engineering wiki structure #1192
  • Conventions around schema used for test cases. #1193
• Full stack and general work:
  • Add E2E test for converting a text column of numbers to a number column #1128
  • Set up linting rule to ban Python type annotations #1196
  • Raise the default Playwright page timeout value #1197
  • Install mathesar_types to full-fill some of the important db functions to work with e2e integ Testing #1168
• Backend work:
  • The type inference algorithm should use TEXT rather than VARCHAR #1121
  • Tests that depend on schema fixture in import/test_csv throws up integrity error when run individually #689
  • Column API should support creating columns without names  #555
  • Fix undefined displayed during import preview for values in column named with a trailing space #1177
  • Remove column_index from MathesarColumn class #996
• Frontend work:
  • Blur via keyboard after entering edit mode on a NULL cell should cancel edits #929
  • Add ESLint rule to prohibit explicitly marking class members as public #1195
  • Focus state being reset by browser in pagination component #1040
  • undefined shown as id column type during import #867
  • Add context menu to set cell value to NULL #930
  • Clicking on the name in 'Manage Schemas' page should set is as the current schema and redirect to base page #985
  • Add ContextMenu component #1213

[kgodey]

Frontend priorities

1. Get open PRs merged:
   1. Number component #1155
   2. Add E2E test for converting boolean type to text type #1182
   3. Fixes #1131 - Add E2E tests for checking the toggle button  #1204
   4. issue-1134 Insert newlines in TextAreaCell only via keyboard shortcut #1211
   5. Bump minimist from 1.2.5 to 1.2.6 in /mathesar_ui #1225
   6. Refactor TableRecord interface to Row #1229
2. Make progress on high-priority issues for Initial Data Types milestone:
   1. NumberInput component improvements #970
   2. Decide on date/time formatting string syntax #1108
   3. Frontend implementation for Boolean Mathesar type #257
   4. Improve UX when adding new records to a table with a NOT NULL column #775
3. Continue working on other Initial Data Types frontend issues.

@pavish @seancolsen Please comment below with thoughts/concerns.

[seancolsen]

Looks good.

[pavish]

Sounds good to me

[kgodey]

Backend priorities

1. Get open PRs completed and merged:
   1. Minor refactor recycled from closed PR #1174
   2. Accept display options for MathesarMoney type #1205
   3. Type logic refactor #1222
   4. Add a Unique constraint to Table model #1223
2. Complete remaining backend work for Initial Data Types:
   1. @dmos62:
      1. Resolve logic duplication in the db.types namespace #1100
      2. Add database type alias information to database type endpoint #1037
   2. @mathemancer
      1. Implement grouping for Text types. #408
      2. Implement grouping options for the email type #411
      3. Implement grouping options for the URI type #414
      4. Implement range based grouping for numeric types. #384
      5. Implement grouping options for date & time types #429
      6. Implement grouping options for money types #419
      7. Implement grouping options for duration type #432
   3. @silentninja:
      1. Implement display options for the custom Money type #1105
      2. Internal server error after column type is converted from text to boolean with display options  #1228
   4. Not assigned to core team members:
      1. API should validate input for number columns #1145 (assigned to @ManishShah120)
      2. Batch updating column using /tables/ api should reference column using id instead of column_index #1167 (assigned to @ratika-12)
      3. Custom python class to represent "char" DB type #1214 (assigned to @Cronus1007)
3. Start work on backend work for Links between Tables, some ideas:
   1. Modify constraints API to list foreign key constraints #943
   2. API support for storing "record preview" and "record selector" settings #944
   3. Ensure integrity of columns with foreign key constraints applied #973
   4. API support for "Link Table" dialog #972
4. Set up style guide and tooling for consistency in backend code #1008

@dmos62 @mathemancer @silentninja Please comment below with thoughts/concerns.

[kgodey]

Design priorities

1. Complete one round of review for Design for visual query builder ("Data Explorer") #1065
2. Submit spec for Design for List data type #978

@ghislaineguerin @ppii775 Please comment below with thoughts/concerns. @ppii775, please let us know if you have any questions about writing the design spec.

[kgodey]

Product priorities

No product work is planned for this week.

[kgodey]

Comms Assignee schedule

Week	Person
2022-03-28 to 2022-04-01	Sean
2022-04-04 to 2022-04-08	Ghislaine
2022-04-11 to 2022-04-12	Kriti
2022-04-13 to 2022-04-15	Dominykas
2022-04-18 to 2022-04-22	Brent
2022-04-25 to 2022-04-29	Kriti
2022-05-02 to 2022-05-06	Pavish
2022-05-09 to 2022-05-13	Mukesh

Instructions

You can also find the schedule and instructions for the Comms Assignee on the wiki page. Please feel free to update the wiki page if you think of anything useful during your shift.

[dmos62]

How did your most recent work go?

I'm learning a lot about the codebase while doing the type logic refactor. And, I'm delaying a lot of the other tasks, like PR reviews. I feel like the focus that gives me is useful, but I'll happily switch tasks if I'm blocking someone.

What are you planning to work on soon?

I'm currently working through the tests affected by the refactor. It's taking some time. I'll do my best to at least submit for review during this week, before my week off.

Do you anticipate any dependencies or blockers that someone else on the team can help you with?

No.

[kgodey]

I don't think you're blocking any contributor PRs and since you're going on vacation at the end of the week, I think it's fine to focus on getting the refactor done over PR reviews. It would be good if you could see #1174 merged this week as well.

[mathemancer]

How did your most recent work go?

Pretty well. I've been getting tests written for grouping and also spending plenty of time on comms for GSoC hopefuls. PR reviews and messaging have taken lots of time, but I think that's okay. I found some irritating details as I wrote tests for ranged grouping, but I'm sorting those out as they arise.

What are you planning to work on soon?

I should have a working PR in to complete number type grouping soon, and the methods are somewhat reusable for text grouping so I'll move into that. I'm also keeping an eye (and a half) on GSoC comms and PR reviews. I'm trying to stay extra available for checking in with @dmos62 since he's going to be gone next week and is working on a pretty big and complex refactor.

Do you anticipate any dependencies or blockers that someone else on the team can help you with?

Nope.

[pavish]

Pavish's check in

How did your most recent work go?

Pretty good. I raised the PR for display options groundwork and a small refactoring PR with it. There were a lot more PR reviews and discussions than the previous week, which took some time, but went well. Overall, the week was very productive for me.

What are you planning to work on soon?

I'm planning on completing:

• Lower-order selection list component and headless selection utilities #1250
• Frontend implementation for Boolean Mathesar type #257 (Sadly, I had to keep delaying this because of the sheer amount of groundwork required inorder to make things easier for other types and for FK configuration)
• Figure out date & time type implementation.
• I expect a considerable amount of PR reviews and discussions this week as well.

Do you anticipate any dependencies or blockers that someone else on the team can help you with?

None.

[ghislaineguerin]

How did your most recent work go?

Pretty good, feels like we have a good foundation for the rest of the views design. I liked presenting the design during our weekly meeting and having discussions before posting the spec.

What are you planning to work on soon?

• Review round for Design for visual query builder ("Data Explorer") #1065
• Start design work for Support for opening and interacting with a View #466

Do you anticipate any dependencies or blockers that someone else on the team can help you with?

• None

[kgodey]

How did your most recent work go?

Not great, I didn't have any time for focused work (being out sick didn't help). I'm generally caught up with review and notifications and discussions and so on.

What are you planning to work on soon?

I have a bunch of meetings and administrative tasks this week (writing job descriptions, etc.). Other than that, I'd like to finish:

• Set up style guide and tooling for consistency in backend code #1008
• Create pages for new engineering wiki structure mathesar-wiki#41

Do you anticipate any dependencies or blockers that someone else on the team can help you with?

Nope.

[seancolsen]

Sean's check in

How did your most recent work go?

• Going okay. I wish I had more time to code though.

What are you planning to work on soon?

• Improve UX when adding new records to a table with a NOT NULL column #775 is my highest-priority task.
• Also on comms this week.

Do you anticipate any dependencies or blockers that someone else on the team can help you with?

• Nope

[silentninja]

Mukesh's check in

How did your most recent work go?

• Pretty good overall. Happy to have started working on the issues in Link with tables milestone.

What are you planning to work on soon?

• Fix bugs with display options and get the Money type display options merged.
• Modify constraints API to list foreign key constraints #943
• Modify constraints API to support creating foreign key constraints #942

Do you anticipate any dependencies or blockers that someone else on the team can help you with?

• Nope

[kgodey]

@silentninja I assume you'll be working on other stuff other than display options too, right?

[silentninja]

Fix bugs with display options and get the Money type display options merged

This is an immediate concern. I have updated the planning to work list with the next set of issues I would be working on.