-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle human readable number casting in general #1309
Comments
Marking this as blocked until #1107 is solved. |
@mathemancer I would like to work upon this issue once it gets unblocked. |
HI @kgodey I am located in India (IST) Hoping for a response soon !!! |
@SatabrataPaul-GitAc I don't have much time available but if you're interested in frontend work, @rajatvijay is wiling to meet with you. |
@kgodey can i work on this issue? |
Sure go ahead @Aditramesh |
Can I have assistance on this issue, I am trying to work on this issue, where exactly in the code files should the enhancement be done? |
This is something that you need to figure out on your own while working on the issue. Please ask more specific questions, this makes it easier and faster for us to provide help. Also, you should look at the "Additional Context" section in the issue description. It links #1137 which should give you some headstart. |
This issue is still relevant, but needs to be improved and clarified.
I'm going to leave it open, but block it and add some labels. |
Problem
Currently, casting from textual types (e.g.,
TEXT
) to numbers relies on the default PostgreSQL number handling. This will be solved for theNUMERIC
type once #1107 is solved, but we should also handle other number types.Proposed solution
We should write custom logic to allow handling casting more strings to number types.
NUMERIC
.INTEGER
) should use a subset of that logic that handles only grouping separators.Additional context
This was originally inspired by the custom casting work for money types. See #1137 . This issue should complete the work begun when solving #1107 .
The text was updated successfully, but these errors were encountered: