Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URI cells clickable #1322

Closed
seancolsen opened this issue Apr 27, 2022 · 0 comments · Fixed by #1349
Closed

Make URI cells clickable #1322

seancolsen opened this issue Apr 27, 2022 · 0 comments · Fixed by #1349
Assignees
Labels
help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@seancolsen
Copy link
Contributor

Reproduce

  1. "New Table" > "Import Data" > "Copy and Paste Text" > paste the following

    project,repo
    Mathesar,https://github.com/centerofci/mathesar
    
  2. Load the table

  3. Expect to find a way to click on the URL in the cell and load the page in my browser

  4. Observe the URL is not clickable

Specs

  • The overall behavior should be similar to AirTable, as in this example:

    Peek 2022-04-27 12-33

  • The URL should only be clickable when the cell is selected

  • Only the text itself should be clickable -- not the padding around it. I should still be able to click in the cell but below the text. This way I can enter edit mode via double click, even with the cell is selected (if I double click within the padding).

  • The URL should be underlined while viewing, but not while editing.

  • The text color should be black when the link is not clickable and blue when the link is clickable.

  • Clicking on the link should open the page in a new tab

@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory help wanted Community contributors can implement this labels Apr 27, 2022
@seancolsen seancolsen added this to the [07] Initial Data Types milestone Apr 27, 2022
@seancolsen seancolsen changed the title Make URL cells clickable Make URI cells clickable May 4, 2022
@seancolsen seancolsen self-assigned this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant