Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the user to work with Postgres MONEY values with our Money UI type #1403

Open
seancolsen opened this issue May 27, 2022 · 1 comment
Open

Allow the user to work with Postgres MONEY values with our Money UI type #1403

seancolsen opened this issue May 27, 2022 · 1 comment
Labels
needs: implementation specs We need clarity on HOW we'll implement it from a technical perspective restricted: maintainers Only maintainers can resolve this issue type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone
Icebox

Comments

@seancolsen
Copy link
Contributor

Current behavior

  • Our Money UI type may not work very well with the built in Postgres MONEY type. Rather, it's built around our own type MATHESAR_TYPES.MATHESAR_MONEY.

  • The precise shortcomings of the incompatibility between our UI type and the Postgres MONEY type are not yet known. The work to resolve this ticket includes further testing. You should use psql to manually set up a table with a MONEY column and test out the behavior to see what additional work is needed.

Desired behavior

  • It's still somewhat unclear how much of the UI functionality we want to support for the built in Postgres MONEY type. Some previous specs are in Frontend implementation for Money Mathesar type #259 but they may need further consideration, as much of the design for the Money UI type has changed since those specs were written.
@seancolsen seancolsen added status: draft type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory restricted: maintainers Only maintainers can resolve this issue labels May 27, 2022
@seancolsen seancolsen added this to the [Beta] Better Editing Experience milestone May 27, 2022
@seancolsen seancolsen mentioned this issue May 27, 2022
Merged
7 tasks
@kgodey kgodey modified the milestones: [Beta] Better Editing Experience, Support for Existing Databases Jun 2, 2022
@github-actions
Copy link

This issue has not been updated in 90 days and is being marked as stale.

@github-actions github-actions bot added the stale label Dec 20, 2022
@kgodey kgodey modified the milestones: Support for Existing Databases, 2023 or later Jan 5, 2023
@pavish pavish removed the stale label Mar 15, 2023
@seancolsen seancolsen added needs: implementation specs We need clarity on HOW we'll implement it from a technical perspective and removed status: draft labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: implementation specs We need clarity on HOW we'll implement it from a technical perspective restricted: maintainers Only maintainers can resolve this issue type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Status: Draft
Milestone
Icebox
Development

No branches or pull requests
3 participants
@seancolsen @kgodey @pavish