Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hint system so that it doesn't have to be stubbed #1983

Closed
dmos62 opened this issue Nov 25, 2022 · 3 comments
Closed

Fix hint system so that it doesn't have to be stubbed #1983

dmos62 opened this issue Nov 25, 2022 · 3 comments
Labels
affects: architecture Improvements or additions to architecture affects: dx Related to developer experience affects: technical debt Improves the state of the codebase type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Milestone

Comments

@dmos62
Copy link
Contributor

dmos62 commented Nov 25, 2022

We're currently hardcoding on the frontend what filters, preproc functions are available and/or how they can be used. We designed the hint system for that, but there was some problem with that, so we ended up hardcoding, and postponed fixing the actual problem.

I don't recall what the actual problem was. @pavish do you have insights?

@dmos62 dmos62 added type: enhancement New feature or request affects: dx Related to developer experience affects: architecture Improvements or additions to architecture affects: technical debt Improves the state of the codebase work: backend Related to Python, Django, and simple SQL status: draft labels Nov 25, 2022
@dmos62 dmos62 added this to the 02. Post-Release Improvements milestone Nov 25, 2022
@pavish
Copy link
Member

pavish commented Mar 15, 2023

@dmos62 The hint system we have is too general for the frontend to make use of. The parsing and restructuring the response requires the frontend to be aware of all the hints, and hardcoding the stub was much easier since the frontend had to know about the hints anyway.

This can be discussed further when the issue is picked up.

@pavish pavish changed the title Fix filter/hint system so that it doesn't have to be stubbed Fix hint system so that it doesn't have to be stubbed Mar 15, 2023
@dmos62
Copy link
Contributor Author

dmos62 commented Mar 16, 2023

@pavish not sure what you mean by parsing and restructuring the response. I remember there was a significant feature missing in the hint system, but I don't recall what it was. I expect that this discussion will come up when we get to formula columns and similar features.

@Anish9901
Copy link
Member

@pavish I'm closing this since it seems irrelevant. Please reopen it if you feel otherwise.

@Anish9901 Anish9901 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: architecture Improvements or additions to architecture affects: dx Related to developer experience affects: technical debt Improves the state of the codebase type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

No branches or pull requests

3 participants