Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to remove a comment on a schema #3638

Closed
Anish9901 opened this issue Jun 24, 2024 · 2 comments · Fixed by #3649
Closed

Unable to remove a comment on a schema #3638

Anish9901 opened this issue Jun 24, 2024 · 2 comments · Fixed by #3649
Labels
type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Milestone
Beta

Comments

@Anish9901
Copy link
Member

TODO

Refactor comment_on_schema SQL functions to remove the comment on a schema if the comment is NULL instead of returning NULL.
@Anish9901 Anish9901 added type: bug Something isn't working work: backend Related to Python, Django, and simple SQL labels Jun 24, 2024
@Anish9901 Anish9901 added this to the Beta milestone Jun 24, 2024
@seancolsen
Copy link
Contributor

@Anish9901 why is this needed for beta?

@Anish9901
Copy link
Member Author

Well..., it's quite low effort and we've already done it for tables and columns, also we currently set the comment to '' instead of NULL when removing it.

@Anish9901 Anish9901 mentioned this issue Jul 2, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Allow unsetting schema comment using NULL mathesar-foundation/mathesar
2 participants
@seancolsen @Anish9901