Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oy_clean() steps #5

Open
matt-dray opened this issue Aug 1, 2019 · 2 comments
Open

oy_clean() steps #5

matt-dray opened this issue Aug 1, 2019 · 2 comments

Comments

@matt-dray
Copy link
Owner

These should be dates/times:

  • Date
  • Start.Time
  • End.Time

Journey.Action should be split into multiple columns, like:

  • mode (train, bus, etc)
  • from station
  • to station

Charge is already numeric and zero. Credit will be money, so it should be numeric and NA should be 0? Maybe not; is there a conceptual difference between no charge for a journey (e.g. because of a season ticket) and credit, which is like one-off repayments? balance is numeric and okay.

Need some Note examples to see how they could be split to provide new columns of data.

@matt-dray
Copy link
Owner Author

  • Handle no tap-out
  • Handle journey action for updating a season ticket

@matt-dray
Copy link
Owner Author

In the July/August vignette example the charge and credit columns are numeric. I think credit should always be numeric (update oy_read() with as.numeric()?), but looks like charge can include season ticket (may need to separate this out into a separate column to leave charge with numeric values only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant