Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group tools should not have an enable/disable checkbox #49

Closed
maximbircu opened this issue May 2, 2020 · 0 comments · Fixed by #51
Closed

Group tools should not have an enable/disable checkbox #49

maximbircu opened this issue May 2, 2020 · 0 comments · Fixed by #51
Assignees
@maximbircu
Labels
android Relates to Android platform bug Something isn't working

Comments

@maximbircu
Copy link
Owner

maximbircu commented May 2, 2020 •
edited
Loading

Abstract

A group tool doesn't have a state, which means that it can not be enabled/disabled. Thus we should hide the enable/disable checkbox forever.

Platform related info:

  • OS: Android, iOS
  • Library version: 1.0.0

Steps to reproduce

  1. Go to any configuration file, i.e. YAML config file
  2. Find the group tool
  3. Try to add canBeDisabled: true property

Expected
The enable checkbox should not be present

Actual
The enable checkbox ist present

Screenshots
@maximbircu maximbircu added bug Something isn't working android Relates to Android platform labels May 2, 2020
@maximbircu maximbircu self-assigned this May 2, 2020
@maximbircu maximbircu mentioned this issue May 2, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximbircu maximbircu

Labels
android Relates to Android platform bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide enable/disable checkbox for group tools maximbircu/devtools-library
1 participant
@maximbircu