Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarking test to Actions workflows #38

Open
medley56 opened this issue Mar 28, 2024 · 1 comment
Open

Add benchmarking test to Actions workflows #38

medley56 opened this issue Mar 28, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@medley56
Copy link
Owner

Add a benchmarking script as a Github action that executes on PR updates, similar to the unit tests and linting. This script should do a basic check to make sure that the performance of the library is not drastically hampered by recent changes and will serve as a way to measure performance gains from planned performance enhancement changes.

@medley56 medley56 added the enhancement New feature or request label Mar 28, 2024
@medley56 medley56 added this to the Version 5.0.0 Release milestone Mar 28, 2024
@medley56
Copy link
Owner Author

@greglucas I assigned this to you because I think you already have a script that does some level of benchmarking. It could be neat to benchmark both "headers only" and also "full packet parsing" for a known data file and packet structure. We can put a tolerance on the amount of acceptable variance in parsing time and fail if the threshold is crossed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants