Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unit Tests Still Using Bitstring #56

Closed
medley56 opened this issue Aug 29, 2024 · 0 comments · Fixed by #58
Closed

Fix Unit Tests Still Using Bitstring #56

medley56 opened this issue Aug 29, 2024 · 0 comments · Fixed by #58
Assignees
Labels
bug Something isn't working

Comments

@medley56
Copy link
Owner

medley56 commented Aug 29, 2024

We have a number of parsing unit tests that are still using ConstBitStream as their input data. This works still but we want to eventually move everything to using PacketData instead.

This may require some changes or additions to PacketData as we discover breaking changes between the ConstBitStream and PacketData objects.

Specific tests in test_xtcedef.py:

test_string_parameter_parsing
test_integer_parameter_parsing
test_float_parameter_parsing
test_enumerated_parameter_parsing
test_binary_parameter_parsing
test_boolean_parameter_parsing
test_absolute_time_parameter_parsing
@medley56 medley56 added the bug Something isn't working label Aug 29, 2024
@medley56 medley56 added this to the Version 5.0.0 Release milestone Aug 29, 2024
@medley56 medley56 assigned medley56 and unassigned greglucas Aug 29, 2024
@medley56 medley56 linked a pull request Aug 30, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants