-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Janus crash libwebsockets #1627
Comments
Try compiling with libasan, as that will give much more relevant info on the crash: https://janus.conf.meetecho.com/docs/debug |
Thanks. I will update Janus to the latest version and recompile with libasan. |
Might be related, coming from #1588, Janus rev ce8255e |
Sure. I will update today to the latest version available for download in github. |
Also, are there any available Janus logs for the crashes? |
No... sorry. I will enable logging to file this time (level 4 by default) |
Level 5 would be better for debugging |
ok. It's 5 now. Let's see it the problem happens again... Thanks! |
That's clearly an issue with your plugin, or whatever the irm plugin is, not Janus... You're incorrectly using the SDP utils and so it crashes. Closing as not a Janus issue. |
Hi. |
It is still happenning version: 0b80a02 There is a situation where janus crashes (apparently when closing a ws connection) |
Be that as it may, this still involves a proprietary plugin, and we have any idea what it does (it may be part of the issue). If you can replicate it with one of the stock plugins, happy to have a look. |
PS: mh, looks like in that specific case it crashed while sending a response to a |
Hi Lorenzo, Thanks for your reply. |
@danflu thanks! I added some implementation considerations there, just in case it helps identifying the root cause of the issue. |
@danflu can you give the pull request above a try? |
@lminiero, Sure...! Will rebuild janus and test again... |
@danflu any update? |
Hi @lminiero... it is still happening in the same place. |
I analysed all my code very carefully... I could not spot any error... I will try put a sleep just inside "plugin->destroy_session" notification. I noticed the create session and destroy session notification come from different threads. Maybe if they happen near the same time the context is invalidated somehow... or just a mismatched retain/release among different threads... really not sure... Detailed crash log: |
If the patch didn't help please notify it on the libwebsockets issue, and provide them with the info they're asking for, as it means I don't know what (if anything) we're doing wrong then. |
Ok. It's running with debug lws... |
The situation I think is happening (looking at it as a complete noob from the SKY): Edit: Detailing a bit more...
Not sure about the ordering of the lws events... This is the pattern I did recognize so far... maybe the web client is creating some kind of edge situation that the server is not prepared to handle. Edit2: apparently it is not related... it crashed today 4 times and not all situations were explained by the above steps... the only thing that do not change is the stack trace. |
Sure! I will test and provide you feedback! |
@lminiero to test your changes, shoud I rollback the changes pointed by the link below ? Since I made then the server did not crash anymore (24 hours up until now) |
Maybe I can keep it since it just avoids the server to crash due assertion... |
I think it's a good idea to rollback those changes, just to see if we can avoid the crashes even without updating the library: not everyone will update their libwebsockets installation, so it would be good to know if we have a fix on our side as well. |
OK! Will rollback and test again with your changes. |
Thanks! |
@danflu any update on this? Do you feel we can merge this and consider it a win? |
Hi @lminiero no crashes in janus/libwebsockets so far, 48 hours up and running !!! |
Sounds good! |
Closing, thanks for the precious feedback and, most importantly, for your patience 😄 |
Thank you! Still up and running :-) |
Hi, Janus is crashing randomly when using websockets and videoroom plugin.
The stacktrace is provided below.
When query git HEAD version by using command:
git rev-parse HEAD
It returns:
ddde5e2
Any ideas ? Thanks a lot!
The text was updated successfully, but these errors were encountered: