-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Janus 0.7.2 crash when leaving videoroom #1685
Comments
Hi @pgj007, |
@atoppi I confirm a crash at line 2375, room is the second element of janus_videoroom_publisher (mov rax,QWORD PTR [rax+0x8], now rax is room), and I suspect something is wrong with the lock. |
Hi @pgj007, |
Hi @atoppi Your temporary solution is to send "detach" before "leave", am I correct? As I am not familiar with janus, I need to look at it again. Thank you! |
If you intend to leave a room and do not reuse the existing Janus handle, just send a |
@atoppi Yes, you're right. There's no need to leave. This problem you can write down first, can close first. Thank you for your answer. |
Is it still an issue with master, or can we close this? |
this is still an issue |
@pgj007 @akbarattar3 could you please test the PR #1795 ? |
@pgj007 @akbarattar3 any update on what @atoppi asked? The patch has been around for more than a week and we haven't received any feedback. If you don't come back to us soon, we'll just assume it's fixed and merge the PR. |
private void closeInternal() {
|
Sorry, but I have no idea what you're talking about. That is not Janus code. Please only provide feedback on a clean Janus installation, as crashes happening on modified forks are out of scope. |
Unless you mean that's your Android client? Is that crashing, or Janus? |
yeah Android client is crashing |
Then it has nothing to do with this issue. We're only interested in figuring out if our patch fixes a crash in the videoroom. |
Merged the fix in #1795, so I'll close this. |
The text was updated successfully, but these errors were encountered: