-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQTT transport enhancement: properties of the status message #1871
Comments
If this is related to the pull request you opened, please link them explicitly. EDIT: sorry, just noticed that's another issue, not a PR... (still jet-lagged). Not sure what you're asking for here, and if it has anything to do with #1872? |
There isn't any PR for this issue yet and it doesn't relate to #1872. The proposal is to add a list of properties to the app's configuration that would be sent along with the payload of the status message. That doesn't change anything in a sense of how Janus plugins work, but it will allow a bit more flexible integrations with other MQTT components. In our particular case, we have some required properties that need to be sent with any MQTT message. |
I assume that by "along with the payload" you mean as additional MQTT properties, and not embedded in the JSON of the message itself, correct? If so, sounds good then! To be honest, though, we don't have plans to work on that, as we're hugely busy on other things and don't use MQTT much ourselves. In case a pull request is provided, happy to look at it 👍 |
That's correct.
We'll prepare a PR in the nearest future. |
Thanks for the clarification, looking forward to the enhancements! |
@manifest @lminiero out of the scope of this issue, am trying to use mqtt transport. i notice all demos have not used mqtt. and all client libs do not use it. could you please shade some light on how client will work to be more specific, lets say how will client screenshare using mqtt transport? |
@uwejan This documentation covers Transport API for all supported protocols including MQTT. You can also check our plugin and signaling server out for more details. |
@manifest is this functionality still required? I'm wondering if the issue can be closed, or if you were indeed still planning to contribute this new feature. To my knowledge no one else seemed to be asking for it, so if it's not needed anymore I can close this. |
Closing as there doesn't seem to be interest in this feature anymore. |
We already have a way to specify a message body for the status message.
The proposal is to allow specifying message properties for the status message from within MQTT transport plugin configuration. By default, properties won't be set (the current behavior).
The text was updated successfully, but these errors were encountered: