-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS H264 issue in janus v0.10.5 #2330
Comments
Does the same happen with Firefox or another ios device? |
Works fine in safari, So I don't think there will be any problem in iOS
|
That error (Failed to execute 'setLocalDescription' on 'RTCPeerConnection') will happen if you don't have the h264 profile set properly. How exactly are you creating the room? You should definitely be seeing 42e01f in the fmtp line if the room is set correctly, so it looks like the room doesn't have the h264_profile set. Have you also set the "videocodec" parameter to "h264" for the room? |
@kimilpyoung setting |
@kimilpyoung you would better to use vp8 in safari, from ios 13.5, the baseline profile (42e01f) - which is compatible with janus - had a very bad quality. |
Yes, when I made a room, I set up codec h264 and h264_profile and sent it The sdp below is the answer sdp received from janus on ios
|
Can you post your code for creating the room (or room config file). And what are the exact steps to recreate? (Connect first on browser/ios version, then on ...?) |
First, this is the create command sent when creating.
And, This is an offer sdp sent from iOS to janus.
|
After creating a room with iOS, access the room with chrome |
Sorry for the wrong click. |
Seems to work fine for me when I do that. What device are you running chrome on? Do you get a "success" reply to that message and then join the room? Also, just note that "ptype" is an invalid parameter for the "create" message. I'm not sure if it matters, but you could try removing that. Also just bear in mind that if the room already exists, "create" won't do anything, so try stopping and starting janus to make sure no old rooms exist (or delete all empty rooms if you don't want to restart the server). |
The device running chrome is mac (os X) Both the server and the app print a successful message And, The server keeps restarting to recreate the videoroom. |
This does NOT look like an offer from your client. Are you sure ? |
This Sdp is created by iOS. |
It clearly isn't, since it has |
Sorry. Confused with another sdp. 42e01f profile doesn't seem to be suggested Does this suggestion differ from the 0.9.5 and 0.10.5 versions of Janus? It's about the part that applies to the server. |
If the device doesn't offer that profile, how is Janus expected to set it in the answer? |
as a side note: while checking this issue we have found out and fixed a problem that caused Janus to reject the video m-line if a participant tries to publish himself for a second time using a h264 profile different from the one configured in the video room. |
It was a question of whether there was any change in the way it was handled in the previous version. |
Thank you. We will try again with the latest version of the commit |
The only change is that Janus now allows plugins to prefer a profile over another, which is what we try to do. If the profile isn't there, though (which is your case), we'll answer with the first profile we find (which is what we did before). |
#2211 |
But... It doesn't seem to be resolved yet. Let’s try and find the cause |
As already mentioned, there is nothing wrong in Janus here. Try to use |
Closing as not an issue. |
+1 |
i used janus v0.10.5
transfer from iOS to janus video room with h264
All other devices(android, web) are visible in chromed
but ios isn't
chrome sdp just
"DOMException: Failed to execute 'setLocalDescription' on 'RTCPeerConnection': Failed to set local answer sdp: Failed to set local video description recv parameters."
this doens't happen in version 0.9.0
When creating videoroom, h264_profile was also created with 42e01f but the error is same
The text was updated successfully, but these errors were encountered: